Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42498 )
Change subject: ACPI S3: Clean up resume path ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c@174 PS1, Line 174: die("Failed OS resume\n");
Should we reset instead?
If wake_vector above was lost for S3 resume path, we would not reach here but skip to BS_WRITE_TABLES. I might be a little towards system_reset() for these cases.
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c@176 PS1, Line 176: return BS_WRITE_TABLES;
this statement is now unreachable
Done