Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40570 )
Change subject: soc/intel/jasperlake: Add function to display ME firmware status info
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/in...
File src/soc/intel/jasperlake/include/soc/me.h:
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/in...
PS5, Line 21: invoke_enhance_dbg_mode: 1;
This is marked as reserved in the CSE BIOS specification document.
https://review.coreboot.org/c/coreboot/+/40570/5/src/soc/intel/jasperlake/in...
PS5, Line 36: u32 reserved_7: 2;
: u32 reserved_9: 2;
: u32 resered_11: 3;
: u32 resered_14: 16;
: u32 reserved_30: 2;
If we are not planning to inspect the fields, why can't they be just one chunk of 25 reserved bits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6b1c9410db8f06ac24fd997772b2ede04264bee
Gerrit-Change-Number: 40570
Gerrit-PatchSet: 5
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 May 2020 16:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment