7 Aug
2020
7 Aug
'20
7:19 a.m.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee... PS6, Line 3: $(abspath .) ugh, i just tried this and it doesn't do what i thought :( all these Makefile.incs get included in the top level makefile so this computes the top level dir.
--
To view, visit https://review.coreboot.org/c/coreboot/+/44272
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66
Gerrit-Change-Number: 44272
Gerrit-PatchSet: 6
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Aug 2020 07:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment