Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74103 )
Change subject: mb/google/myst: Enable console UART
......................................................................
Patch Set 24:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74103/comment/20953a60_fe080f44
PS24, Line 10: # UART0
i'd say that the comment is unnecessary since we're using the uart_0 alias
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52c1b86c46907216d88f98917968b833af0d5d41
Gerrit-Change-Number: 74103
Gerrit-PatchSet: 24
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 14:16:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment