Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41023 )
Change subject: mb/ocp/deltalake: Enable IPMI KCS ......................................................................
mb/ocp/deltalake: Enable IPMI KCS
Config the IO port for IPMI KCS and set bmc_boot_timeout for checking BMC self test result.
TEST=Check if the BMC IPMI reponse data is correct or not.
Change-Id: I675060299b486986ebc39d8f714615b3e13de89a Signed-off-by: Morgan Jang Morgan_Jang@wiwynn.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41023 Reviewed-by: Jonathan Zhang jonzhang@fb.com Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/devicetree.cb 2 files changed, 14 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Jonathan Zhang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index 679115a..d61a3a6 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -8,6 +8,11 @@ select MAINBOARD_USES_FSP2_0 select SOC_INTEL_COOPERLAKE_SP select SUPERIO_ASPEED_AST2400 + select IPMI_KCS + +config IPMI_KCS_REGISTER_SPACING + int + default 4
config MAINBOARD_DIR string diff --git a/src/mainboard/ocp/deltalake/devicetree.cb b/src/mainboard/ocp/deltalake/devicetree.cb index 26912d1..2586b73 100644 --- a/src/mainboard/ocp/deltalake/devicetree.cb +++ b/src/mainboard/ocp/deltalake/devicetree.cb @@ -36,6 +36,8 @@ register "coherency_support" = "0" register "ats_support" = "0"
+ register "gen2_dec" = "0x000c0ca1" # IPMI KCS + device cpu_cluster 0 on device lapic 0 on end end @@ -70,7 +72,13 @@ device pci 1c.4 on end # PCI bridge: Intel Device a214 device pci 1c.5 on end # PCI bridge: Intel Device a215 device pci 1d.0 on end # PCI bridge: Intel Device a218 - device pci 1f.0 on end # ISA bridge: Intel Device a245 + device pci 1f.0 on + chip drivers/ipmi # BMC KCS + device pnp ca2.0 on end + register "bmc_i2c_address" = "0x20" + register "bmc_boot_timeout" = "60" + end + end # ISA bridge: Intel Device a245 device pci 1f.1 on end # p2sb device pci 1f.2 on end # Memory controller: Intel Device a221 device pci 1f.3 on end # Audio device: Intel Device a270