Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 23:
(4 comments)
Patch Set 20: Code-Review-1
please fix port C0 config.
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/1//COMMIT_MSG@9 PS1, Line 9: Create the Mudada variant of the volteer.
We copy it from volteer folder and modify settings follow mudada design .
Done
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte... PS20, Line 118: (GPP_S0,
Dear Sathyanarayana, […]
Done
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee... PS7, Line 5: chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S : end : end
My bad. sorry about that.
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 56: device pci 1f.2 hidden : # The pmc_mux chip driver is a placeholder for the : # PMC.MUX device in the ACPI hierarchy. : chip drivers/intel/pmc_mux : device generic 0 on : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "9" : register "usb3_port_number" = "1" : # SBU & HSL follow CC : device generic 0 on end : end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" : device generic 1 on end : end : end : end : end # PMC
Delbin port C1 follow design of volteer. So we use the same setting on port C1 as volteer.
Done