Martin Roth (gaumless@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6496
-gerrit
commit ccc16cfa1224d025d41a66978f30fc10781c8147 Author: Martin Roth martin.roth@se-eng.com Date: Mon Aug 4 17:23:06 2014 -0600
cbfstool error: -v gives THOUSANDS of lines of bad output.
This is not intended for submission. I just ran cbfstool with the -v option, trying to debug an issue I was seeing, and suddenly I had TWO issues...
There's a problem in cbfstool here, and I don't have time to debug it further than this right now. If anyone feels like looking at it, I offer this up to them.
Here's part of the output: PAYLOAD build/coreboot.pre add-payload -f payloads/memtest86+/memtest.elf -n img/memtest -c LZMA -v img/memtest 0xe09700 payload 46951 0x41544144 ((unknown) compression, offset: 0x38, load: 0x10000, length: 46895/192808 0x52544e45 (none compression, offset: 0x0, load: 0x10000, length: 0/0 0x3000001 ((unknown) compression, offset: 0x0, load: 0x7e4081b787ec, length: 2020815957/363341946 0x314cc703 ((unknown) compression, offset: 0x42eeb380, load: 0x90b3ccab6100c86, length: 1916715941/-378419934 0xeb8788ab ((unknown) compression, offset: 0xf3b21c77, load: 0x62e8dea3da480ad0, length: -1342285081/-1389218217 0x246d75f4 ((unknown) compression, offset: 0xa881bd58, load: 0x6ee3e7be0c88cc21, length: -504708229/1612905668 ... (removed 400,000+ lines) 0x0 (none compression, offset: 0x0, load: 0x0, length: 0/0 0x0 (none compression, offset: 0x0, load: 0x0, length: 0/0 0x0 (none compression, offset: 0x0, load: 0x0, length: 0/0 0x0 (none compression, offset: 0x0, load: 0x0, length: 0/0 0x0 (none compression, offset: 0x0, load: 0x0, length: 0/0 make: *** [payloads/memtest86+/memtest.elf] Segmentation fault (core dumped)
Change-Id: Ie2effd76894e824db4012baf9ac10dd79a79a113 Signed-off-by: Martin Roth martin.roth@se-eng.com --- util/cbfstool/cbfs_image.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 12bc2fe..234be5f 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -684,13 +684,13 @@ int cbfs_print_entry_info(struct cbfs_image *image, struct cbfs_file *entry, case CBFS_COMPONENT_PAYLOAD: payload = (struct cbfs_payload_segment *) CBFS_SUBHEADER(entry); - while (payload) { +// while (payload) { cbfs_print_payload_segment_info(payload, fp); - if (payload->type == PAYLOAD_SEGMENT_ENTRY) - break; - else - payload ++; - } +// if (payload->type == PAYLOAD_SEGMENT_ENTRY) +// break; +// else +// payload ++; +// } break; default: break;