[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43980 )

Change subject: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
PS3, Line 123: TcssD3ColdEnable
> D3ColdEnable setting is expected to be enabled. […]

if we change TcssD3ColdEnable to TcssD3ColdDisable:

params->D3ColdEnable = !!config->TcssD3ColdDisble

we won't need a device tree entry at all unless someone needs to
explicitly disable it for some exceptional case.