Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER
Woops, vendor value is without ownership... […]
I suggest to abandon this patch, but not change PAD_CFG_GPO_GPIO_DRIVER to PAD_CFG_GPO in all files now. I think, we shouldn't to resolve global issues in this patch. This weekend I will make a separate patch (remove PAD_CFG_GPO_GPIO_DRIVER) in which we will have a discussion about these macro. It's already used in some boards from google, intel, siemens. I believe that DRIVER mode is GPI related only and the PAD_CFG_GPO_GPIO_DRIVER macro isn't correct, however, we should be careful with such changes :)