[coreboot-gerrit] [S] Change in coreboot[master]: device/mdio: Provide helper functions for read and write

[Mario Scheithauer (Code Review)]

Attention is currently required from: Werner Zeh.

Hello Werner Zeh,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/69611

to review the following change.

Change subject: device/mdio: Provide helper functions for read and write
......................................................................

device/mdio: Provide helper functions for read and write

This patch provides helper functions to read or write a register via the
MDIO bus. They can be used from drivers to easily access registers on
the MDIO bus.

Change-Id: I293d93435d27269a071b4b9b94a1b55307c575a7
Signed-off-by: Werner Zeh 
---
M src/device/mdio.c
M src/include/device/mdio.h
2 files changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/69611/1

diff --git a/src/device/mdio.c b/src/device/mdio.c
index 9f560e6..39ac40b 100644
--- a/src/device/mdio.c
+++ b/src/device/mdio.c
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

+#include <assert.h>
 #include <console/console.h>
 #include <device/device.h>
 #include <device/mdio.h>
@@ -14,3 +15,26 @@

return dev->ops->ops_mdio;
 }
+
+uint16_t mdio_read(struct device *dev, uint8_t offset)
+{
+	const struct mdio_bus_operations *mdio_ops;
+	struct device *parent = dev->bus->dev;
+
+	assert(dev->path.type == DEVICE_PATH_MDIO);
+	mdio_ops = dev_get_mdio_ops(parent);
+	if (!mdio_ops)
+		return 0;
+	return mdio_ops->read(parent, dev->path.mdio.addr, offset);
+}
+void mdio_write(struct device *dev, uint8_t offset, uint16_t val)
+{
+	const struct mdio_bus_operations *mdio_ops;
+	struct device *parent = dev->bus->dev;
+
+	assert(dev->path.type == DEVICE_PATH_MDIO);
+	mdio_ops = dev_get_mdio_ops(parent);
+	if (!mdio_ops)
+		return;
+	mdio_ops->write(parent, dev->path.mdio.addr, offset, val);
+}
diff --git a/src/include/device/mdio.h b/src/include/device/mdio.h
index 39e60f5..44ce48b 100644
--- a/src/include/device/mdio.h
+++ b/src/include/device/mdio.h
@@ -14,4 +14,7 @@
 /* Helper for getting mdio operations from a device */
 const struct mdio_bus_operations *dev_get_mdio_ops(struct device *dev);

+uint16_t mdio_read(struct device *dev, uint8_t offset);
+void mdio_write(struct device *dev, uint8_t offset, uint16_t val);
+
 #endif	/* __DEVICE_MDIO_H__ */