Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nico Huber.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h ......................................................................
Patch Set 5:
(1 comment)
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80695/comment/3ba1e0ac_b81812ce : PS5, Line 60: AZALIA_LOCATION_UNKNOWN
Would something like AZALIA_LOCATION_NOT_APPLICABLE make more […]
I chose "unknown" for consistency with the others. I think you have a point here though. Maybe, we could `s/UNKNOWN/NOT_APPLICABLE/` since I feel like this also makes sense for `COLOR_UNKNOWN` and `TYPE_UNKNOWN` and this would also keep the consistency as well.
I would highly discourage anyone from using this value in mainboard configurations after the merge locations patch. However, I would still prefer to keep this value.