Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33765 )
Change subject: soc/amd/picasso: Update calculation for TSC frequency
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33765/4/src/soc/amd/picasso/tsc_fre...
File src/soc/amd/picasso/tsc_freq.c:
https://review.coreboot.org/c/coreboot/+/33765/4/src/soc/amd/picasso/tsc_fre...
PS4, Line 38: return (100 * (cpufid + 0x10)) / (0x01 << cpudid);
If this is constant, you may want to cache the result (declare static variable for return value) as rdmsr is sometimes heavy for execution and worth skipping when possible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I909743483309279eb8c3bf68852d6082381f0dff
Gerrit-Change-Number: 33765
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jul 2019 14:02:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment