Attention is currently required from: Ashish Kumar Mishra, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change by Ashish Kumar Mishra. ( https://review.coreboot.org/c/coreboot/+/83420?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: vc/google/chromeos: Add configurable compression for logo file in cbfs ......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/google/chromeos/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83420/comment/8a878c6d_fc79b193?usp... : PS2, Line 29: ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) : cb_logo.bmp-compression := LZMA : else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) : cb_logo.bmp-compression := LZ4 : endif : BMP_LOGO_COMPRESS_FLAG := none ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) BMP_LOGO_COMPRESS_FLAG := LZMA else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) BMP_LOGO_COMPRESS_FLAG := LZ4 endif
That way you can use it in both cb_logo and cb_plus_logo i.e. ``` cb_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG) cb_plus_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG) ```