Attention is currently required from: Nico Huber, Sukumar Ghorai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75898?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/intel/mtlrvp: disable acpi timer for xtal shutdown ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75898/comment/d9191bc7_bac4470a : PS3, Line 9: acpi timer need to disable for xtal shutdown
Acknowledged
You missed the *be*.
https://review.coreboot.org/c/coreboot/+/75898/comment/1b75a1f3_29e67a4d : PS3, Line 9: acpi timer need to disable for xtal shutdown, requirement for : platform to enter deepest sleep s0i2.2.
https://review.coreboot.org/c/coreboot/+/75822/3/src/soc/intel/meteorlake/pm.... […]
Ok, thank you. It says it in that comment. It’d be great to have the datasheet name/section.
Commit Message:
https://review.coreboot.org/c/coreboot/+/75898/comment/e4afba72_fbd49ab1 : PS4, Line 11: How did you test this? Please add a TEST= line.
Patchset:
PS4: The Kconfig help text says:
This should be disabled for devices running on battery since it can draw much power. Further, it must be disabled, if S0ix is enabled.
Can’t this be determined programmatically, if S0ix is supported or not?