Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49896 )
Change subject: cpu/intel/microcode: Add caching layer around intel_microcode_find
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/intel/microcode/microcode.c:
https://review.coreboot.org/c/coreboot/+/49896/comment/7c9bd596_ac1abf2c
PS2, Line 181: #if ENV_STAGE_HAS_DATA_SECTION
Hmm, I thought that static doesn't work in XIP stages. might be wrong.
You can use `static` in early stages as long as you don't need to initialise things with a non-zero value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49896
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic40d57964600f8f20ddb26c7d1691b043fd89f29
Gerrit-Change-Number: 49896
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 25 Jan 2021 12:26:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment