Attention is currently required from: Hung-Te Lin, Raul Rangel, Matt DeVillier, Julius Werner, Rob Barnes, Andrey Petrov, Xi Chen, Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Christian Walter, Lean Sheng Tan, Fred Reitberger, Felix Held.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66170 )
Change subject: timer: Change timer util functions to 64-bit
......................................................................
Patch Set 10:
(4 comments)
File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/66170/comment/1c2bd381_efeedb74
PS10, Line 177: llds
This seems to be wrong as previous this was 'us' which now turned to 's'.
https://review.coreboot.org/c/coreboot/+/66170/comment/b46fa867_dbf22e55
PS10, Line 463: %llds
same here
https://review.coreboot.org/c/coreboot/+/66170/comment/98d4cc19_3c28b7ce
PS10, Line 544: %llds
and here
https://review.coreboot.org/c/coreboot/+/66170/comment/cfde3b84_682f3855
PS10, Line 552: %llds
and here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I169588f5e14285557f2d03270f58f4c07c0154d5
Gerrit-Change-Number: 66170
Gerrit-PatchSet: 10
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 12 Sep 2022 09:07:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment