Attention is currently required from: Sean Rhodes, Jeremy Soller, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56256 )
Change subject: src/soc/intel/*: Change legacy_8254_timer to CMOS option ......................................................................
Patch Set 2:
(3 comments)
File src/soc/intel/cannonlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123944): https://review.coreboot.org/c/coreboot/+/56256/comment/ab838cb4_4ba251ba PS2, Line 431: params->Enable8254ClockGating = !legacy_8254_timer;; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123944): https://review.coreboot.org/c/coreboot/+/56256/comment/851bd0db_653594a7 PS2, Line 432: params->Enable8254ClockGatingOnS3 = !legacy_8254_timer;; Statements terminations use 1 semicolon
File src/soc/intel/jasperlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123944): https://review.coreboot.org/c/coreboot/+/56256/comment/3525efd5_aa843f68 PS2, Line 91: params->Enable8254ClockGating = !legacy_8254_timer;; Statements terminations use 1 semicolon