Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34141 )
Change subject: riscv: Remove unused header
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c
File src/arch/riscv/stages.c:
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c@27
PS1, Line 27: #include <arch/encoding.h>
: #include <arch/stages.h>
: #include <arch/smp/smp.h>
: #include <rules.h>
: #include <mcall.h>
There is still one more include than external identifiers used in the code.
So at least one more spurious include. Please clean it up at once.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cd03e043e1bc2795b98d6ec2f88efa5b50d872b
Gerrit-Change-Number: 34141
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 28 Jul 2019 09:45:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment