Attention is currently required from: Cliff Huang, Dolan Liu, Eric Lai, Kapil Porwal, Lance Zhao, Paul Menzel, Subrata Banik, Tim Wawrzynczak.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email )
Change subject: acpi: Make acpi_device_write_dsd_gpio() public
......................................................................
Patch Set 11:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81788/comment/dc39402a_cdc63b49 :
PS8, Line 7: Add acpi_device_write_dsd_gpio for public
Make acpi_device_write_dsd_gpio() public
Done
https://review.coreboot.org/c/coreboot/+/81788/comment/d9cdf15f_0349a940 :
PS8, Line 9: use
used
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/81788/comment/b8cbaee9_00805f59 :
PS9, Line 10:
Please describe, what happened with `i2c_generic_write_gpio()`.
Done
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/81788/comment/6d9d130a_f939b130 :
PS9, Line 47: if (!curr_index)
if (!gpio || !curr_index)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 11
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 17 Apr 2024 09:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment