Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83374?usp=email )
Change subject: xcompile: Use CLANG_CFLAGS_${TARCH} option per line ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1: Otherwise it looks good to me.
File util/xcompile/xcompile:
https://review.coreboot.org/c/coreboot/+/83374/comment/ae05488c_264ffc75?usp... : PS1, Line 265: CLANG_CFLAGS_${TARCH} += -Qunused-arguments -m${TWIDTH} ```suggestion CLANG_CFLAGS_${TARCH} += -Qunused-arguments CLANG_CFLAGS_${TARCH} += -m${TWIDTH} ```
https://review.coreboot.org/c/coreboot/+/83374/comment/a1c3c343_e56065f4?usp... : PS1, Line 273: CLANG_CFLAGS_${TARCH} += -fbracket-depth=2048 -mllvm -asm-macro-max-nesting-depth=1000 ```suggestion CLANG_CFLAGS_${TARCH} += -fbracket-depth=2048 CLANG_CFLAGS_${TARCH} += -mllvm CLANG_CFLAGS_${TARCH} += -asm-macro-max-nesting-depth=1000 ```