[coreboot-gerrit] Change in coreboot[master]: cbgfx: Add blend functions to calculate transparency

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43358 )

Change subject: cbgfx: Add blend functions to calculate transparency
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43358/3/payloads/libpayload/drivers... 
File payloads/libpayload/drivers/video/graphics.c:

https://review.coreboot.org/c/coreboot/+/43358/3/payloads/libpayload/drivers... 
PS3, Line 188: need_blend ?
             : 		  apply_blend(rgb->red, blend.rgb.red) : rgb->red
> Functionality, no.  But if you think that it helps with readability, then let's put it in.

Doesn't ">>" has higher precedence than "a?b:c", so that

a ? x : y >> shift

will be interpreted as

a ? x : (y >> shift)