Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt DeVillier, Fred Reitberger, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64951 )
Change subject: soc/amd/noncar/memlayout.ld: Warn about incorrect reset vector
......................................................................
Patch Set 13:
(2 comments)
File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:
https://review.coreboot.org/c/coreboot/+/64951/comment/c2ae7c58_e7c57d7f
PS11, Line 150: be
be or end with?
Well in 16 bit real mode IP really is 0xfff0. A shadow CS deals with the other bits.
https://review.coreboot.org/c/coreboot/+/64951/comment/25dffdf6_f77f3ba6
PS11, Line 150: 0xfff0
shouldn't this be 0xffff? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibced50e4348a2b46511328f9b3f3afa836feb9a5
Gerrit-Change-Number: 64951
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 05 Nov 2022 11:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment