Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 51:
(36 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/366aada1_7bbebd00 PS51, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/416fccf6_5aba453c PS51, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/35618bcc_f89a4c59 PS51, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/0ec489b6_72da9311 PS51, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/67568835_aef72a68 PS51, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/682f8b36_6af39691 PS51, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/df7c5f31_7d42e00f PS51, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/8003ef84_7ba0b7c9 PS51, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/6062ea55_831e9811 PS51, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/97d01ae8_c196a479 PS51, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/f7820e32_eed0424c PS51, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/75259d4c_fde51c89 PS51, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/d5623171_9e91aa53 PS51, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/a87e2031_80944c50 PS51, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/068a0802_16d75e41 PS51, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/a4eef2ac_5be7663e PS51, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/6f45caca_7a79dbea PS51, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/a394dd1f_283552c5 PS51, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/17923304_e8bbd4e1 PS51, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/0b11b662_0b442309 PS51, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/e9390256_7b6ae953 PS51, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/b4b3fc7b_a0ed4398 PS51, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/34ba4c3d_038d6003 PS51, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/ac8087f9_13ef98fd PS51, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/55ded362_f46b980b PS51, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/e34bae6e_a4e0e931 PS51, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/b088a8e1_f77952f0 PS51, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/ae01f4dd_8c65be5b PS51, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/8e9588ec_7fe7bea8 PS51, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/fa4e6efc_95744179 PS51, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/d79a1178_5b53e99f PS51, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/f590497a_84d99cd1 PS51, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/68fbdbd5_f520a5cd PS51, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/cb025469_c3a5ae0b PS51, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/0dc14b21_ae51e1bf PS51, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159849): https://review.coreboot.org/c/coreboot/+/23586/comment/f063463f_61655133 PS51, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const