Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )
Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation
......................................................................
Patch Set 1:
Patch Set 1:
When I leave the blob default, I get prompted (in a different
location non-obvious location) for CPU_MICROCODE_CBFS_LEN
and CPU_MICROCODE_CBFS_LOC. Those have non-working default
values (0). Resulting in a brick.
With a reasonable default here, the open-source NEM-enhanced,
everything works fine.
We can make NEM-enhanced a default option then but in past IOTG folks wishes to make FSP-T usage for them. i believe default can be overriden so they can still use FSP-CAR if wishes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a880f3093887628ce6bc9c39758e43688345713
Gerrit-Change-Number: 34166
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 09 Jul 2019 10:42:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment