Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family.
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7
PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
1. Please remove the dot at the end of the commit message summary.
2. I think the common prefix is different for variants.
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@11
PS2, Line 11: special
: configuration
variant?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753
Gerrit-Change-Number: 34344
Gerrit-PatchSet: 2
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Mon, 15 Jul 2019 11:12:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment