[coreboot-gerrit] Change in coreboot[master]: security/vboot: Build vboot library with same .a that depthcharge uses

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36341 )

Change subject: security/vboot: Build vboot library with same .a that depthcharge uses
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36341/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36341/1//COMMIT_MSG@9 
PS1, Line 9: Switch from fwlib20 to fwlib
> I'm confused by this. […]

No, vboot_reference is a in a weird spot right now w/r/t ver1 / 2.0 / 2.1, etc.

vboot_fw.a contains:
${FWLIB_OBJS} ${FWLIB2X_OBJS} ${FWLIB20_OBJS}

vboot_fw20.a contains:
${FWLIB20}: ${FWLIB2X_OBJS} ${FWLIB20_OBJS}

Which means that we can change coreboot to link against vboot_fw.a, which is what depthcharge does right now, so they're using the "same" library instead of different ones, which is weird, confusing, and possibly fraught with peril.