build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46282 )
Change subject: nb/intel/pineview: Get rid of MCHBARxx_{AND_OR,AND,OR} macros ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46282/1/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/46282/1/src/northbridge/intel/pinev... PS1, Line 1361: mchbar8_unset_and_set(C0DCOMPx(i), 0x03, rcompdelay2[s->dimm_config[0]]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/46282/1/src/northbridge/intel/pinev... PS1, Line 1458: mchbar8_unset_and_set(C0SLEWPULUTx(2) + i, 0x3f, rcomplut[j][10]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/46282/1/src/northbridge/intel/pinev... PS1, Line 1479: mchbar8_unset_and_set(C0SLEWPDLUTx(2) + i, 0x3f, rcomplut[j][11]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/46282/1/src/northbridge/intel/pinev... PS1, Line 2362: mchbar16_unset(HICLKGTCTL, 0x03ff mchbar16_unset(HICLKGTCTL, 0x03ff mchbar16_unset(HICLKGTCTL, 0x03ff & 0x06); 0x06); 0x06); line over 96 characters