Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... PS13, Line 16: if [[ ! -e /etc/cros_chroot_version ]]; then : echo "This script must be run inside the chroot" : exit 1 : fi What's needed in the chroot? If it needs to be run in the chroot, why push it to coreboot.org? Why not put it in the public overlay?
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... File util/mainboard/google/hatch/dptf.asl.tmpl:
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... PS13, Line 4: * Copyright __YEAR__ Google LLC We're getting rid of all the copyright lines and just having the AUTHORS file instead.
Google LLC is there already, so I'd just skip all the copyright lines.
For an example, see: https://review.coreboot.org/c/coreboot/+/35177