[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd: Add amdfw.rom in coreboot.pre

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Jason Glenesk, Martin L Roth, Matt DeVillier, Arthur Heymans, Fred Reitberger, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66943 )

Change subject: soc/amd: Add amdfw.rom in coreboot.pre
......................................................................

Patch Set 14:

(1 comment)

File src/soc/amd/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/66943/comment/b8920167_fea94c3f 
PS8, Line 23: $(call int-add, \
            : 	$(call int-subtract, 0xffffffff \
            : 	$(call int-shift-left, \
            : 	0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1)
> Does this help - https://review.coreboot. […]

I take your comment on CB:68584 as we are going in the right direction. Hence marking this as resolved and address all your comments in that one.