Attention is currently required from: KunYi Chen, Martin L Roth, Nicholas Chin.
Nicholas Sudsgaard has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/lattepanda/mu/devicetree.cb:
PS8: Missing SPDX license.
https://review.coreboot.org/c/coreboot/+/83719/comment/d81f121e_9d7b6c77?usp... : PS8, Line 9: register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # USB3/2 Type A : register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" # USB3/2 Type A : register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # USB2 Type A : register "usb2_ports[3]" = "USB2_PORT_EMPTY" : register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # USB2 Type A : register "usb2_ports[5]" = "USB2_PORT_EMPTY" : register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # M.2 E 2230 : : register "usb3_ports[0]" = "USB3_PORT_EMPTY" : register "usb3_ports[1]" = "USB3_PORT_EMPTY" : register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A : register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A : Use this format, and place it under `xhci`. ``` register "usb2_ports" = "{ [0] = USB2_PORT_MID(OC_SKIP), // comment ... }" ```