HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40370 )
Change subject: nb/i945: Rewrite peg_bits for MCHBAR16(UPMC1) ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40370/3/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/40370/3/src/northbridge/intel/i945/... PS3, Line 2174: /* FIXME bits 5 and 0 only if PCIe graphics is disabled */
Why would you need to risk breaking things by changing this??? […]
why will this break something???? We all know that there is no documentation .... and what we used to read registry on vendor (see util/inetl* ) and some reverse engineering. so I did that and found it written that way.