Attention is currently required from: Raul Rangel, Nico Huber, Patrick Georgi, Kyösti Mälkki.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61307 )
Change subject: console: Add ANSI escape sequences for highlighting
......................................................................
Patch Set 3:
(1 comment)
File src/commonlib/include/commonlib/loglevel.h:
https://review.coreboot.org/c/coreboot/+/61307/comment/0788a7b1_e86604ee
PS3, Line 190: BIOS_LOG_ESCAPE_PATTERN
Looks like this isn't used. […]
It's used in the next patch in the cbmem utility. But more importantly, it's just here for documentation purposes. I tried a bunch of different ways to describe in the comment how to use this ("you have to first print this piece and then the string and then this other piece...") until I eventually realized that just giving the printf pattern is really the most clear and unambiguous way to document it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61307
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I868f4026918bc0e967c32e14bcf3ac05816415e8
Gerrit-Change-Number: 61307
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 03 Feb 2022 00:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment