Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23690
Change subject: [TEST] Fix CAR for P4 CPU's ......................................................................
[TEST] Fix CAR for P4 CPU's
when reading cpuid(4) it looks like the wrong ecx argument is provided (4 instead of 0), despite what to code does. This leads to a division by 0 later which has the code do wrong stuff.
Change-Id: I00cf86259d5c5c6e46e41a516cf585bbc11a26a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/intel/car/cache_as_ram_ht.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/23690/1
diff --git a/src/cpu/intel/car/cache_as_ram_ht.inc b/src/cpu/intel/car/cache_as_ram_ht.inc index e716caf..64e6083 100644 --- a/src/cpu/intel/car/cache_as_ram_ht.inc +++ b/src/cpu/intel/car/cache_as_ram_ht.inc @@ -136,6 +136,7 @@ movb $1, %bl cmpl $4, %eax jb cores_counted + movl $0, %ecx movl $4, %eax movl $0, %ecx cpuid