Attention is currently required from: Joey Peng. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56802 )
Change subject: mb/google/brya/variant/taeko: Update devicetree settings ......................................................................
Patch Set 14: Code-Review+1
(5 comments)
Patchset:
PS14: Looking good, just a few minor adjustments 😊
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56802/comment/639d1281_9c9e49a0 PS14, Line 119: 0x2c nit: all the other i2c addresses in this file do not use the `0x` prefix. drop it for consistency.
https://review.coreboot.org/c/coreboot/+/56802/comment/0f3b279a_ce3da895 PS14, Line 129: end nit: will fit on the previous line (`device generic 0 on end`)
https://review.coreboot.org/c/coreboot/+/56802/comment/4c136b88_c6a71dab PS14, Line 193: device ref pmc hidden Above the `pmc` device, I think you want to add:
``` device ref pch_espi on chip ec/google/chromeec use conn0 as mux_conn[0] use conn1 as mux_conn[1] device pnp 0c09.0 on end end end ```
https://review.coreboot.org/c/coreboot/+/56802/comment/a6c1ce42_75ea7d26 PS14, Line 204: conn2 nit: `conn1`