Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43958 )
Change subject: soc/mediatek/mt8192: Add PLL and clock init support
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43958/4/src/soc/mediatek/mt8192/pll...
File src/soc/mediatek/mt8192/pll.c:
https://review.coreboot.org/c/coreboot/+/43958/4/src/soc/mediatek/mt8192/pll...
PS4, Line 457: setbits32(&mtk_topckgen->clk_scp_cfg_0 , 0x3ff);
space prohibited before that ',' (ctx:WxW)
please fix this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49342c058577e8e107b7e56c867bf21532e40d2
Gerrit-Change-Number: 43958
Gerrit-PatchSet: 4
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 06:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment