Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42882 )
Change subject: documentation: Add documentation for Purism Librem Mini ......................................................................
Patch Set 6:
(11 comments)
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... File Documentation/mainboard/purism/librem_mini.md:
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 40: by build
by *the* build
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 69: ### External programming
Are there diodes on the flash chip's voltage rail? […]
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 74: 2 top cover screws, 4 screws securing the mainboard to the chassis, and 4 screws : securing the heatsink/fan assembly to the mainboard (under the SODIMMs).
Make it a list?
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 76: wifi
Wi-Fi
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 77: wifi
Wi-Fi
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 85: - SATA issues with some devices have been mitigated by limiting the SATA speed to 3Gbps
Oh, there are SATA issues?
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 91: kg
Pkg
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 93: AP
Access Point?
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 98:
trailing space
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 99: Suspend/Resume
Prefix with "S3"
Done
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... File Documentation/mainboard/purism/librem_mini.png:
PS3:
I'd prefer a picture that shows the flash chip location, preferably with pin 1 clearly visible and m […]
Done