Attention is currently required from: Alexander Couzens, Felix Singer, Nicholas Chin, Nico Huber, Paul Menzel.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80343?usp=email )
Change subject: mainboard/lenovo: Add ThinkCentre M710s (Skylake) ......................................................................
Patch Set 16:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80343/comment/f35c368e_0444d418 : PS15, Line 33: - SATA ACPI error
Could you paste a log snippet for that?
``` ACPI BIOS Error (bug): Could not resolve symbol [_SB.PCI0.SATA], AE_NOT_FOUND (20230331/dswload2-162) ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20230331/psobject-220) ```
It does not affect general use, so I haven't looked into it.
File src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80343/comment/63dee91d_6cdc3cd0 : PS15, Line 46: register "SataMode" = "SATA_AHCI"
AHCI is the default, remove.
Done
File src/mainboard/lenovo/thinkcentre_m710s/romstage.c:
https://review.coreboot.org/c/coreboot/+/80343/comment/cada8668_921494b6 : PS15, Line 10: const u16 rcomp_resistors[] = {121, 75, 100}; : const u16 rcomp_targets[] = {60, 26, 20, 20, 26};
nit: could be put within mainboard_memory_init_params() as they are memcpy'd anyway.
Done