Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38378 )
Change subject: drivers/spi/spi_flash: introduce common spi_flash_part_id object ......................................................................
Patch Set 1:
src/drivers/spi/spansion.c: In function 'match_table': src/drivers/spi/spansion.c:164:50: error: 'params' may be used uninitialized in this function [-Werror=maybe-uninitialized] flash->size = flash->sector_size * (1U << params->nr_sectors_shift); ~~~~~~^~~~~~~~~~~~~~~~~~
This is weird that the ARM compiler detects this as being potentially uninitialized. I can't fathom why it's drawing that conclusion, tbh.