12 Sep
2022
12 Sep
'22
11:42 a.m.
Attention is currently required from: Angel Pons, Alexander Couzens, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67540 )
Change subject: mb/lenovo/haswell: Enable VBOOT_VBNV_FLASH ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/lenovo/haswell/vboot-rwab.fmd:
https://review.coreboot.org/c/coreboot/+/67540/comment/dfe1d84c_fb549de4 PS1, Line 24: SMMSTORE(PRESERVE)@0x523000 0x40000 Now this is not aligned to 64K anymore. Does building with SMMSTORE succeed? It has a buildtime check for alignment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1430ffd6115a0bc151cbe0632cda7fc5f6c26a6
Gerrit-Change-Number: 67540
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Mon, 12 Sep 2022 08:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment