Attention is currently required from: Daniel Schaefer, Jean Lucas, Kieran Levin, Nicholas Chin, Paul Menzel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81978?usp=email )
Change subject: mb/framework: Initial push of azalea (Framework 13 AMD 7040) ......................................................................
Patch Set 5:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81978/comment/844875fe_94b0443e : PS5, Line 7: Initial push of azalea
Make it a statement? […]
Done.
File src/mainboard/framework/azalea/Kconfig:
https://review.coreboot.org/c/coreboot/+/81978/comment/57975f9c_ba2aa42c : PS5, Line 6: if BOARD_FRAMEWORK_AZALEA
Add a blank line above (as in the abandoned CB:81992)
Done
https://review.coreboot.org/c/coreboot/+/81978/comment/639a203c_26542924 : PS5, Line 16: endif
Nit: Add a blank line above
Done
File src/mainboard/framework/azalea/Kconfig.name:
PS5:
Missing SPDX header
Done
File src/mainboard/framework/azalea/Makefile.inc:
PS5:
Should be Makefile. […]
Bah!
Thanks. I've had this on my machine for a while, so missed that change.
File src/mainboard/framework/azalea/board_info.txt:
https://review.coreboot.org/c/coreboot/+/81978/comment/8b96cdfd_eabaffd6 : PS5, Line 2: Board name: Azalea (13" AMD Ryzen 4070)
Typo, 7040*
Heh. Done, thanks.
File src/mainboard/framework/azalea/bootblock.c:
https://review.coreboot.org/c/coreboot/+/81978/comment/9696902a_e1fa05df : PS5, Line 3: #include <bootblock_common.h>
nit: add blank line
Done
File src/mainboard/framework/azalea/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/81978/comment/3e8b8c9e_ed02fdfa : PS5, Line 12: )
nit: remove that tab
Done