Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35880 )
Change subject: kbl boards / fsp2.0: remove redundant CdClock setting
......................................................................
Patch Set 1:
Patch Set 1:
Naresh, do you remember why you explicitly set this for the
KBLRVP?
I'm not sure what FSP version I was using when working on this.
But I guess the HW/Display needed this frequency.
For reference :
FSP master:(Kaby Lake FSP 3.6.0 )
https://github.com/IntelFsp/FSP/blob/master/KabylakeFspBinPkg/Include/FspsUp...
FSP older version (Kaby Lake FSP 3.1.0)
https://github.com/IntelFsp/FSP/blob/16d143d63854938fceec60b762ae1b25aa48dbf...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bd7f3dc4c795691a04d2eaba0e2458ee50aabb
Gerrit-Change-Number: 35880
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Hung-Te Lin
hungte@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Naresh Solanki
naresh.solanki.2011@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 04:28:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment