[coreboot-gerrit] [M] Change in coreboot[master]: drivers/pc80/vga: Add API to write multi-line video message

[Jérémy Compostella (Code Review)]

Attention is currently required from: Subrata Banik.

Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 )

Change subject: drivers/pc80/vga: Add API to write multi-line video message
......................................................................

Patch Set 8:

(2 comments)

File src/drivers/pc80/vga/vga.c:

https://review.coreboot.org/c/coreboot/+/71265/comment/e3786936_bc5ff384 
PS8, Line 288: char str[VGA_COLUMNS * VGA_LINES] = {0};
             : 	memcpy(str, string, strnlen(string, sizeof(str) - 1));
that seems overkill to allocate 2K of memory on the stack and have to go over the string twice compared to a simple 80 bytes buffer and and loop over a string.

https://review.coreboot.org/c/coreboot/+/71265/comment/73cea6af_b4e18a5c 
PS8, Line 304: 			vga_write_at_offset(line++, 0, token);
What happen when the number of lines exceed VGA_LINES ?
I know that the other functions do not perform any check but considering that this function is a little bit more complex and receive a potentially long string, I believe a check would be worth it.