Attention is currently required from: Reka Norman, Tim Wawrzynczak, Nick Vaccaro.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64461 )
Change subject: mb/google/nissa/var/craask: Disable PCIe WLAN pins
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/craask/gpio.c:
https://review.coreboot.org/c/coreboot/+/64461/comment/8b14bad2_a3010f77
PS2, Line 15: PAD_CFG_GPO(GPP_F12, 1, DEEP),
CB:64270 changes it to NC in the baseboard. […]
Sorry, I don't get it. Refer to CB:64270, GPP_F12 set same as Nivviks in gpio.c.
Does this setting have any problem?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bcf041503dcee448758dac46b1c9711d0b02ba3
Gerrit-Change-Number: 64461
Gerrit-PatchSet: 2
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cathy Chen
cathy_chen@quanta.corp-partner.google.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 02 Jun 2022 03:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment