[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Move SCI to IRQ 10

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/21418 )

Change subject: siemens/mc_apl1: Move SCI to IRQ 10
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainbo...
File src/mainboard/siemens/mc_apl1/mainboard.c:

https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainbo...
PS1, Line 117: static void mainboard_enable(device_t dev)
> Do we really want to have it in the mainboard_enable() function? Are there

If we have the functionality into mainboard_init(), then FSP-S (SiliconInit) will re-route the SCI. If we use mainboard_final(), then it’s too late for acpi_sci_irq().