the following patch was just integrated into master: commit 660ec7cfdf0b48c135ada6cd67af25d66404d3ba Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Wed Jan 14 02:14:21 2015 +1100
drivers/i2c/w83795: Fix tautology from wrong return type
The correct type-signature of 'do_smbus_write_byte' is:
int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, u8 val)
and so storing the return type in a 'u32' is inappropriate, leading to a tautological compare of 'ret < 0' and 'err < 0'.
Change-Id: I65486df7156c70af84fa00c336142d9a45998620 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com Reviewed-on: http://review.coreboot.org/8209 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich rminnich@gmail.com
See http://review.coreboot.org/8209 for details.
-gerrit