Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42413 )
Change subject: cpu/intel/206ax/acpi.c: Fix get_cores_per_package ......................................................................
Patch Set 5: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/42413/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42413/3//COMMIT_MSG@20 PS3, Line 20: Related to #29669.
Done
CB:29669 also works, see? 😄
https://review.coreboot.org/c/coreboot/+/42413/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42413/5//COMMIT_MSG@9 PS5, Line 9: numbers the number
https://review.coreboot.org/c/coreboot/+/42413/5//COMMIT_MSG@14 PS5, Line 14: correct the correct
https://review.coreboot.org/c/coreboot/+/42413/5//COMMIT_MSG@15 PS5, Line 15: processors with and without HT. Was this tested? If so, I'd mention which hardware this was tested on
https://review.coreboot.org/c/coreboot/+/42413/5/src/cpu/intel/model_206ax/a... File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/42413/5/src/cpu/intel/model_206ax/a... PS5, Line 15: int this should be an unsigned int, but one would have to change several things
https://review.coreboot.org/c/coreboot/+/42413/5/src/cpu/intel/model_206ax/a... PS5, Line 21: logical_cores I would eliminate this variable and `return msr.lo & 0xffff;` directly.