Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer, Angel Pons, Michael Niewöhner. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ......................................................................
Patch Set 4:
(6 comments)
File util/inteltool/gpio_names/tigerlake.h:
https://review.coreboot.org/c/coreboot/+/56171/comment/0256ea90_ede6b086 PS4, Line 336: "Reserved",
one too much. […]
Then, maybe these are GPP_U0, GPP_U1, GPP_U2 and GPP_U3? Possibly undocumented.
https://review.coreboot.org/c/coreboot/+/56171/comment/7c4507ad_1105b289 PS4, Line 535: 3 I think this is actually 5? GPP_C was dumping strangely and it mismatches the pad_count.
https://review.coreboot.org/c/coreboot/+/56171/comment/411f495f_a7e419c9 PS4, Line 575: tigerlake_pch_h_group_e_names "GPP_E0/SATAXPCIE0/SATAGP0" is missing.
https://review.coreboot.org/c/coreboot/+/56171/comment/1919f955_3d3520ea PS4, Line 753: GPP_J GPP_K
https://review.coreboot.org/c/coreboot/+/56171/comment/e973e73b_eae468c6 PS4, Line 759: tigerlake_pch_h_group_r_names "GPP_R0/HDA_BCLK/I2S0_SCLK/n_a/HDACPU_BCLK," "GPP_R1/HDA_SYNC/I2S0_SFRM/n_a/n_a" and "GPP_R2/HDA_SDO/I2S0_TXD/n_a/HDACPU_SDO" are missing.
I am making some guesses as to how the GPIO functions are grouped.
https://review.coreboot.org/c/coreboot/+/56171/comment/390ff272_894c1580 PS4, Line 901: tigerlake_pch_h_communities tigerlake_pch_h_community_3 is missing.