Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41561 )
Change subject: mb/asus/p2b: Enable hardware monitor access via I/O on ISA bus ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41561/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41561/1//COMMIT_MSG@9 PS1, Line 9: Setup
Set up
Done
https://review.coreboot.org/c/coreboot/+/41561/1/src/mainboard/asus/p2b/main... File src/mainboard/asus/p2b/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41561/1/src/mainboard/asus/p2b/main... PS1, Line 16: Setup
The verb is spelled with a space: Set up.
Done
https://review.coreboot.org/c/coreboot/+/41561/1/src/mainboard/asus/p2b/main... PS1, Line 22: 0x60
You can make two commits: one that adds register definitions to i82371eb. […]
Done