Attention is currently required from: SH Kim. Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/58073
to review the following change.
Change subject: mb/google/dedede/var/bugzzy: Update GPP_D5 configuration ......................................................................
mb/google/dedede/var/bugzzy: Update GPP_D5 configuration
As we checked the panel doesn't display firmware screen if we hold GPP_D5(TOUCHSCREEN_RESET) low on bugzzy. It's because of that bugzzy uses the built-in touch screen on the panel, the panel seems like under reset state by the TOUCHSCREEN_RESET signal. This change sets default GPP_D5 level to high for bugzzy.
BUG=b:None BRANCH=dedede TEST=built and verified bugzzy showed firmware screen
Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Change-Id: I53e4fc52ceb14ba23c22d3c105f65634b09029f1 --- M src/mainboard/google/dedede/variants/bugzzy/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/58073/1
diff --git a/src/mainboard/google/dedede/variants/bugzzy/gpio.c b/src/mainboard/google/dedede/variants/bugzzy/gpio.c index ce88b5e..d089162 100644 --- a/src/mainboard/google/dedede/variants/bugzzy/gpio.c +++ b/src/mainboard/google/dedede/variants/bugzzy/gpio.c @@ -21,6 +21,8 @@ PAD_NC(GPP_D1, NONE), /* D3 : WLAN_PCIE_WAKE_ODL ==> NC */ PAD_NC(GPP_D3, NONE), + /* D5 : TOUCHSCREEN_RESET */ + PAD_CFG_GPO(GPP_D5, 1, DEEP), /* D7 : EMR_INT_ODL */ PAD_CFG_GPI_APIC(GPP_D7, NONE, PLTRST, LEVEL, INVERT), /* D13 : EN_PP3300_CAMERA */