[coreboot-gerrit] Change in coreboot[master]: [WIP] mainboard: Add Acer ES1-572

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )

Change subject: [WIP] mainboard: Add Acer ES1-572
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572/... 
File src/mainboard/acer/es1-572/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572/... 
PS5, Line 266: 		device pci 1f.5 off end		# PCH SPI
> lockdown doesn't work, too, because SPIBAR can't be accessed and BILD (bios interface lockdown) can' […]

breaks rom console, too

https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... 
File src/mainboard/acer/es1-572/gpio.h:

https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... 
PS4, Line 105: 	_PAD_CFG_STRUCT(GPP_A19,
why not use PAD_CFG_NC for nc pads?